Skip to content

Use 'nwx_find_package' wrapper find MPI#157

Merged
zachcran merged 3 commits intomasterfrom
find_package_wrapper
Feb 2, 2026
Merged

Use 'nwx_find_package' wrapper find MPI#157
zachcran merged 3 commits intomasterfrom
find_package_wrapper

Conversation

@zachcran
Copy link
Contributor

@zachcran zachcran commented Dec 15, 2025 •
edited
Loading

Description

This PR utilizes the find_package wrappers added by NWChemEx/NWXCMake#59 to find MPI's MPI::MPI_CXX target.

TODOs

  • Verify that it works when built independently
  • Verify that it works when built in Spack

@zachcran zachcran self-assigned this Dec 15, 2025
@zachcran
Copy link
Contributor Author

zachcran commented Jan 28, 2026

Checks can't pass until NWChemEx/NWXCMake#59 is merged.

@zachcran zachcran marked this pull request as ready for review January 28, 2026 19:04
jwaldrop107
jwaldrop107 previously approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@jwaldrop107 jwaldrop107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jwaldrop107
jwaldrop107 previously approved these changes Jan 28, 2026
View reviewed changes
@zachcran
Copy link
Contributor Author

zachcran commented Feb 2, 2026

@jwaldrop107 I'm not sure why the documentation build tests are failing, but this PR doesn't touch those. Any ideas? Otherwise, the test libraries are working now after the fix in NWChemEx/NWXCMake#60.

@zachcran zachcran enabled auto-merge February 2, 2026 18:59
@ryanmrichard
Copy link
Member

ryanmrichard commented Feb 2, 2026

@jwaldrop107 I'm not sure why the documentation build tests are failing, but this PR doesn't touch those. Any ideas? Otherwise, the test libraries are working now after the fix in NWChemEx/NWXCMake#60.

Try changing the Sphinx requirement to version 8.1.

@zachcran
Copy link
Contributor Author

zachcran commented Feb 2, 2026

Try changing the Sphinx requirement to version 8.1.

Do you mean to set something like sphinx>=8.1 or sphinx==8.1 in the requirements.txt file? (here)

Also, I can reproduce this error on my local system even with Sphinx==9.1.0.

@jwaldrop107
Copy link
Member

jwaldrop107 commented Feb 2, 2026 •
edited
Loading

@zachcran Issues over on sphinx_tabs imply that it's not currently compatible with Sphinx 9+, and the test is also running with 9.1. Restricting the sphinx version to 8.x may resolve the failure.

@zachcran
Copy link
Contributor Author

zachcran commented Feb 2, 2026

@jwaldrop107 @ryanmrichard Looks like pinning the Sphinx version worked. Thanks! This is ready to go now, aside from the check that is stuck in queue purgatory (and already passed last time).

@zachcran zachcran merged commit ed1d6b6 into master Feb 2, 2026
4 of 5 checks passed
@zachcran zachcran deleted the find_package_wrapper branch February 2, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryanmrichard ryanmrichard ryanmrichard approved these changes

@jwaldrop107 jwaldrop107 jwaldrop107 approved these changes

Assignees

@zachcran zachcran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zachcran @ryanmrichard @jwaldrop107